TST: CoW with df.isetitem() #50692
TST: CoW with df.isetitem() #50692
Conversation
| assert not np.shares_memory(df["a"].values, df2["a"].values) | ||
|
|
||
| df2.loc[0, "a"] = 0 | ||
| tm.assert_series_equal(df["a"], df_orig["a"]) # Original is unchanged |
There was a problem hiding this comment.
Can we use get_array? A regular getitem sets up references which is what we want to avoid here
There was a problem hiding this comment.
Sorry wrong line, in the np.shares_memory and any reason why we don't compare the whole object?
There was a problem hiding this comment.
Can we use get_array? A regular getitem sets up references which is what we want to avoid here
Changed. Originally, I had put this test in test_setitem.py does the shares_memory checks like this.
Should we change that file over in the future?
Sorry wrong line, in the np.shares_memory and any reason why we don't compare the whole object?
Updated, I had this left over from testing, sorry.
There was a problem hiding this comment.
No worries.
Hm I would not change any existing tests as of right now (still early in CoW adaption). In general this is fine if CoW is not activated, but when explicitly testing CoW we should avoid setting up references to avoid side effects
|
thx @lithomas1 |
xref #49473
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.